Pavel Sanda ha scritto:
once you got commit access the situation will quite improve i think.
you probaly know - but just for sure - we have now bug sorted by components
(search is one of them) here: http://www.lyx.org/trac/wiki/Components
Thanks for the notification. I'm not sure all related bugs have the
"component" field properly set, however I can check these things when
I'm back home (now I'm on too low/high-cost bandwidth)
I think the performance of this feature is acceptable for a release.
yes. i just tried some tests here and i agree that as far as the speed is
concerned the situation is much better than last time i played with it.
Now there is a "two-steps hierarchical search": the matching paragraph
is found first, then the exact position is found next. The resulting
performance is at risk only if we have long documents all written within
some special inset, e.g., sometimes I co-edited documents in which all
of the main contents was within a single table cell. Also, a
multi-paragraph search is not considered of interest as of now (in fact,
typing [Enter/Return] while typing within the Find... WorkArea triggers
the "Find Next" button, and [Shift+Enter/Return] triggers the "Find
Previous" button (and similar thing happens while typing in the Replace
WorkArea). However, it is not disabled, because you can always paste
multiple paragraphs in those WorkAreas.
Concerning the names to use (men?, dialog and tooltips), I'm open to any
suggestion. As of now, the
-) "Find & Replace (plain text)"
Quick find
-) "Find & Replace (formatted)"
Find & Replace
?
I'm temporarily committing:
- "Find & Replace (quick) | F"
- "Find & Replace (advanced)"
On a related note, I don't know why the "C-S-f" short-cut does not
appear in the menu', like it happens for the "C-f" one. Any clue ?
5 min playing:
- dialog should have tickmark in menu as other panels like toc or browse source
have.
(see status flags)
Done.
- the insert->regexp in insert menu should be there? we are overcrowding this
menu
and this is not common inserted inset. also i doubt this should be inserted
into
normal buffer. if its only into findindg dialog we should put in there.
For now, this action is already enabled only within Find/Replace
WorkAreas, and disabled in the document WorkArea (however, you can
always copy&paste regexp insets from Find/Replace WAs into the document
WA :-) ). An alternative I'm thinking of (and I'd really appreciate your
comment on this), is a "Regexp/Find&Replace" toolbar, containing the
"Insert empty regexp" and all the other commonly used regexps, that
automatically shows up when selecting the Find WA (this would free the
"Match..." combo space from the F&R panel)
- i see currently many undo warnings in the console.
The fix I proposed a few days ago was suppressing those warnings, but it
was not actually correct, so this issue is still under investigation.
- some layout work in designer would be needed, so that the two buffers
are resized to bigger ones when the dialog is resized too...
I think I exhausted all of the possible policies (to Expadning) in
designer-qt4, and the horizontal behaviour should be correct (can you
check, please ?). So I guess the problem (for the vertical expansion) is
somewhere-else, where the height of the dialog is forced despite
whatever I set into the ".ui" files.
- i just got
lassert.cpp(21): ASSERTION view().currentMainWorkArea() VIOLATED IN
GuiWorkArea.cpp:1282
Assertion triggered in void lyx::doAssert(const char*, const char*, long int) by failing
check "false" in file lassert.cpp:23
when clicking on the advanced menu when no buffer is opened.
I could reproduce this as: New, C-S-f, File->CloseBuffer. The attached
patch (you'll likely get offsets, I have other non-committed changes)
closes the dialog if it is open, when closing the document buffer (and
fixed this use-case). May I commit ?
- very strange thing switching between basic and advanced tab switches CT
toolbar on and off.
What is the "CT" toolbar ?
- consider adding 'all manuals' into the scope. it would solve one longstanding
issue
I've added the option (disabled, scopes are not implemented yet),
however there is a difference w.r.t. other options, in that the manuals
are not necessarily open. The user could add the manuals of interest
into which to search, then select "All open buffers", and obtain the
same effect.
T.
Index: src/frontends/qt4/GuiView.cpp
===================================================================
--- src/frontends/qt4/GuiView.cpp (revisione 31175)
+++ src/frontends/qt4/GuiView.cpp (copia locale)
@@ -1859,6 +1877,8 @@
bool GuiView::closeBuffer()
{
+ if (isDialogVisible("findreplaceadv"))
+ dispatch(FuncRequest(LFUN_DIALOG_HIDE, "findreplaceadv"));
GuiWorkArea * wa = currentMainWorkArea();
Buffer & buf = wa->bufferView().buffer();
return wa && closeWorkArea(wa, !buf.parent());
