> Looks good.

The patch is in.

>> The HSpace dialog lacks in general support for glue lengths, see
>> http://www.lyx.org/trac/ticket/6099 but this is independent from support
>> for percent lengths.)
>
> Should be easy to implement as well, while you're at it. Just replace the
> Length in InsetSpace by a GlueLength (and again increase the file format).

It is not that easy because Mathed also uses the HSpace dialog and uses routines like "inPixels". (Glue lengths are also valid in Mathed's HSpace inset.) These routines only exist for Length but not for GlueLength. Moreover VSpace.cpp contains many routines to handle glue lengths in the lineEdit field. These are missing for GlueLengths and should be implemented to HSpace.cpp. The HSpace dialog should then use the HSpace class instead of the Length class.

I won't have time to work further on this the next weeks, so please take over as you are deep enough in this business as well as I am.

regards Uwe

Reply via email to