Vincent van Ravesteijn <v.f.vanraveste...@tudelft.nl> writes: >> So the situation might be bit more complicated than I thought. > Yes, at least it is very unclear. At first sight I'd have no clue what > "isActive()" would mean, and wat IS_EDITABLE is and so forth..
If you can think of a good separation of meanings, now would be a good time to do the cleanup. I see that we forgot one: descendable(). It seems to be equivalent to HIGHLY_EDITABLE, although it only covers text insets. This method is only used in BufferView::getCoveringInset, which is in turn used for: * context menus * tooltips * mouse hover So these uses are rather new. The fact that maths is not covered means that inner math insets will not have these features, which is or is not intended. In other words: what about getting rid of this and use HIGHLY_DESCENDABLE? A problem with that will be that math insets will lose their context menu. However, a strategy of concatenation of context menus would fix that. Sorry if this is not very articulate, I am thinking aloud. >> Yes. And you could maybe rename the function to hasSettings()? > Any chance of hasSettings() returning something different than hasDialog() ? No, it is just a matter of name. I prefer to convey that fact that settings can be changed, rather the fact that it is done through a dialog. JMarc
