Vincent van Ravesteijn - TNW wrote:
rgheck wrote:
By the way, can you remember what problem Bennet had which made you
adding the lhs.refresh() and rhs.refresh() lines to
FileName::operator==(). This solution looks a bit like "Abdel's
hammer".
Not right now, no, though it's probably on the list somewhere. But I
think the problem was that, when caching is enabled, the file could
have moved, been deleted, etc, and you'll miss it without a refresh.
http://marc.info/?l=lyx-devel&m=121734075326705&w=2
rh
The thread starts with a problem that would be the consequence of
r25960.
I don't see why refreshing is a solution for a problem that could have
been introduces in r25960. The thread neither gives an answer why and
whether the changes are correct.
The previous == and != checks had just been against the file NAMES,
which meant you could get file1 != file2, if the names were symlinks
pointing to the same file, and names with different capatalizations
would be seen as different on Windows, VFAT, etc. So Abdel changed it to
call QFileInfo::operator==, which dealt with both problems. But that led
to Bennett's problem: The comparison sometimes rested on old data; hence
the need for the refresh.
rh
