Lars Gullik Bjønnes wrote:
> Ok, first of all this has nothing to do with pleasing me...

No? Too bad.

> Why wasn't the obvious change done?
>
>         // do not apply
>         if (!matchCB->isChecked())
>                return;
>
> ?

Because this strikes me less clear.

> and if we take renaming into account...
>
> if matchCV->isChecked is about auto-apply, perhaps that is how it should be
> named?
>
>        if (!matchCB->isAutoApplyChecked())
>                return;

This is a Qt function. We cannot rename it (and auto-apply refers to the LyX 
dialog behaviour, which should be done only if the "match delimiters" checkn 
box is not checked, i.e. matchCB->isChecked())

Jürgen

Reply via email to