On Sun, Mar 15, 2009 at 16:50, <sp...@lyx.org> wrote: > Author: spitz > Date: Sun Mar 15 16:50:40 2009 > New Revision: 28798 > > URL: http://www.lyx.org/trac/changeset/28798 > Log: > please Lars. >
Ok, first of all this has nothing to do with pleasing me... Just as it has nothing to do with pleasing the compiler when you get rid of warnings.... > > Modified: > lyx-devel/branches/BRANCH_1_6_X/src/frontends/qt4/GuiDelimiter.cpp > > Modified: > lyx-devel/branches/BRANCH_1_6_X/src/frontends/qt4/GuiDelimiter.cpp > URL: > http://www.lyx.org/trac/file/lyx-devel/branches/BRANCH_1_6_X/src/frontends/qt4/GuiDelimiter.cpp?rev=28798 > > ============================================================================== > --- lyx-devel/branches/BRANCH_1_6_X/src/frontends/qt4/GuiDelimiter.cpp > (original) > +++ lyx-devel/branches/BRANCH_1_6_X/src/frontends/qt4/GuiDelimiter.cpp Sun > Mar 15 16:50:40 2009 > @@ -296,8 +296,8 @@ > > void GuiDelimiter::on_leftLW_itemActivated(QListWidgetItem *) > { > + // do not auto-apply if !matchCB->isChecked() > if (!matchCB->isChecked()) > - // do not apply > return; Secondly, this just made it worse... Thirdly it can be argued that something is wronly named here if a commend is required. But if we forget renaming for now... Why wasn't the obvious change done? // do not apply if (!matchCB->isChecked()) return; ? and if we take renaming into account... if matchCV->isChecked is about auto-apply, perhaps that is how it should be named? if (!matchCB->isAutoApplyChecked()) return; -- Lgb
