Abdelrazak Younes wrote:
On 07/03/2009 03:22, rgheck wrote:
Jürgen Spitzmüller wrote:
Vincent van Ravesteijn - TNW wrote:
I'm a bit sceptical that someone did the effort to write a FIXME
and to
change updateLabels according to this, just not to implement a
for-loop of
one line of code. Why ? Maybe we miss something and we introduce
another
bug.
That someone was Abdel:
http://www.lyx.org/trac/changeset/25980
Better yet see: http://www.lyx.org/trac/changeset/25977. Note that
the fixed bug was "Crash on copy/paste branch". It turns out Abdel
was absolutely right about what the correct fix was,
I am _always_ right...
but maybe overestimated how much work would be involved. I was pretty
shocked myself that it's a three-liner.
... except when I am wrong of course :-).
You analysis and patch seems to be correct at first glance. As to the
original question, maybe I was more afraid of slowing things down. As
a general rule of thumb, you must ensure that there's only one call to
updateLabel() for a given user action. The only way to ensure that is
to put a break point in updateLabel() and verify that we do not pass
two times by there.
Sorry (again) for letting you all fighting with my bugs...
No problem. We all have bugs.
I did the check. No extra calls, so far as I can see.
rh
