Jean-Marc Lasgouttes wrote:
Pavel Sanda <sa...@lyx.org> writes:
now with back-from-back jump too.
Looks good.
+void BufferView::editBookmarkSave()
I'd really prefer a name like saveEditBookMark. Not necessarily this one
which does not sound so good, but at least one where the first work is
the verb. Maybe bookmarkEditPosition?
+ d->editLastParCache_ = d->cursor_.paragraph().id();
And of course a variable with a name that at least looks like the
function would not hurt :)
... and that respect the coding rules for private members:
edit_last_par_cache_
Finally, how did bookmark 0 work previously? Is this code still there?
Since your new feature does not use the bookmark machinery (and is local
to the document), I think it would be better to have a separate lfun...
You could even save a stack of positions, to get a sort of undo/redo for
positions.
True, I've always used Ctrl-Z Ctrl-Y in order to mimick this feature, so
surely there's a way to implement it using undo/redo :-)
Abdel.
