Jean-Marc Lasgouttes wrote: > Pavel Sanda <sa...@lyx.org> writes: > > now with back-from-back jump too. > > Looks good. > > > +void BufferView::editBookmarkSave() > > I'd really prefer a name like saveEditBookMark. Not necessarily this one > which does not sound so good, but at least one where the first work is > the verb. Maybe bookmarkEditPosition?
no problem > > + d->editLastParCache_ = d->cursor_.paragraph().id(); > > And of course a variable with a name that at least looks like the > function would not hurt :) > Finally, how did bookmark 0 work previously? currently was used only for go-back when you jumped from reference to label. this still works unless you start edit things around, which is ok imho. > Since your new feature does not use the bookmark machinery (and is local > to the document), I think it would be better to have a separate lfun... > You could even save a stack of positions, to get a sort of undo/redo for > positions. actually i started work on back&forward stack but as time was passing the code started to be rather complex without any short outlook for completion. so i stopped it and used this rather simplistic version with the hope for 1.6.3. pavel
