Further investigation:
InsetBibtex
========
In InsetBibtex::Latex(Buffer const *, ostream & os,
bool /*fragile*/, bool/*fs*/) const
use the buffer that is passed but not used.
InsetBibtex::getKeys() is called only from Buffer. Call it as getKeys(this)
No need, therefore to store Buffer * owner in InsetBibtex or to use
current_view.
InsetInclude
=========
A quick glance shows that Buffer * master can be replaced in each of the
Latex(), DocBook(), Linuxdoc() methods.
Are InsetInclude::getMasterFilename() and InsetInclude::Validate() really
sticking points?
Angus
On Wed, 27 Sep 2000, Juergen Vigna wrote:
> On 27-Sep-2000 Angus Leeming wrote:
> > This is a fair point that is valid not only in this case, but in all
> > those insets that store Buffer * buffer directly. Perhaps we should
> > really think hard about how to get rid of this store in all these cases.
>
> Yes we should!
>
> > Incidentally, in the case of InsetQuote, we can find the language in
> > other ways. Shall I do this (see other mail). It doesn't address André's
> > question about whether it's necessary, but it'll work cleanly.
>
> I did it already and "yes" the language IS needed here!
>
> > For reference, the following insets are passed Buffer * in the
> > constructor:
> >
> > figinset.h:23: InsetFig(int tmpx, int tmpy, Buffer *);
>
> [will vanish so no need to think about this on]
>
> > insetbib.h:81: InsetBibtex(InsetCommandParams const &, Buffer *);
> > insetinclude.h:30: InsetInclude(InsetCommandParams const &, Buffer
> > *); insetparent.h:30: InsetParent(InsetCommandParams const &,
> > Buffer * owner = 0);
> > insettabular.h:76: InsetTabular(Buffer *, int rows = 1, int columns =
> > 1); insettabular.h:78: InsetTabular(InsetTabular const &, Buffer *);
>
> At least insettabular does need the stored buffer ONLY for the Clone()
> function! This means that if we add a Buffer * to the Clone() functions
> this is not needed anymore! Lars any thoughts?
>
> Jürgen
>
> --
> -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._
>
> Dr. Jürgen Vigna E-Mail: [EMAIL PROTECTED]
> Italienallee 13/N Tel/Fax: +39-0471-450260 / +39-0471-450253
> I-39100 Bozen Web: http://www.sad.it/~jug
>
> -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._
>
> gossip, n.:
> Hearing something you like about someone you don't.
> -- Earl Wilson
