JMarc> And what happens when insets are copy/pasted to another document?

This is a fair point that is valid not only in this case, but in all those 
insets that store Buffer * buffer directly. Perhaps we should really think 
hard about how to get rid of this store in all these cases.

Incidentally, in the case of InsetQuote, we can find the language in other 
ways. Shall I do this (see other mail). It doesn't address André's question 
about whether it's necessary, but it'll work cleanly.

Angus

For reference, the following insets are passed Buffer * in the constructor:

figinset.h:23:  InsetFig(int tmpx, int tmpy, Buffer *);
insetbib.h:81:  InsetBibtex(InsetCommandParams const &, Buffer *);
insetinclude.h:30:      InsetInclude(InsetCommandParams const &, Buffer *);
insetparent.h:30:       InsetParent(InsetCommandParams const &, Buffer * 
owner = 0);
insettabular.h:76:    InsetTabular(Buffer *, int rows = 1, int columns = 1);
insettabular.h:78:    InsetTabular(InsetTabular const &, Buffer *);           
  

Reply via email to