Vincent van Ravesteijn wrote:

I like it, although I am not 100% sure from your screenshot that all different pairs of colors can be visually matched. And we have no idea of how color blind people react to this.

What is probably strange is that the _deleted color will only be available to the user for changing when has actually deleted text... Since the colors for changes are hardcoded, I am not sure why you do not also hardcode the _deleted colors. The current situation is a bit in the middle of two solutions:

1/ define all colors in Color table
2/ add a bit to FontInfo indicating that the color should be unsaturated/saturated ans let the painter handle it.

I think I prefer solution 2/ since it would be usable for hovering on inset buttons and things like that.
Hi,

Herewith I'd like to propose a different solution. I'd like to hear whether this is a reasonable solution or not.

This looks very reasonable to me.

Abdel.

Reply via email to