On 28/12/2008 12:50, Jean-Marc Lasgouttes wrote:
Le 28 déc. 08 à 01:47, Vincent van Ravesteijn a écrit :
Here is a patch that lowers the saturation for deletions. It is also
possible to increase the saturation as shown in the attached.
If there are strong opinions I'd like to hear them.
Looks good.
I like it, although I am not 100% sure from your screenshot that all
different pairs of colors can be
visually matched. And we have no idea of how color blind people react
to this.
What is probably strange is that the _deleted color will only be
available to the user for changing when
has actually deleted text... Since the colors for changes are
hardcoded, I am not sure why you do not
also hardcode the _deleted colors. The current situation is a bit in
the middle of two solutions:
1/ define all colors in Color table
2/ add a bit to FontInfo indicating that the color should be
unsaturated/saturated ans let the painter handle it.
I think I prefer solution 2/ since it would be usable for hovering on
inset buttons and things like that.
+1
Abdel.
