On 13/10/2008 22:11, Vincent van Ravesteijn wrote:
The piece of code you showed is indeed just renaming, but I think this
makes more sense than the way it was before: if the end margin is
selected, only the left margin is important for RTL text and the right
margin for LTR text.
By the way, bv_->leftMargin() and bv_->rightMargin() are defined exactly
the same. However, when I played with these functions I saw that
altering one of these does something different for RTL text as it does
for LTR text. That's why I added the FIXME's last time (which lead to
doubts from your side).
The patch is not only cosmetics as it always does some 'important'
things: it sets lm and rm to zero, when we are not in the main buffer
(i.e. Insets don't have margins). Second, the other block for
row.begin_margin_sel differ in a number of terms.
OK, I missed that part of the patch indeed. Dov confirmed that it is OK
so, Pavel, if you have it applied locally please commit.
Abdel.
