Abdelrazak Younes wrote:
On 13/10/2008 16:23, Dov Feldstern wrote:
Abdelrazak Younes wrote:
+ if (row.end_margin_sel) {
if (text_->isRTL(buffer, beg.paragraph())) {
- int rm = bv_->rightMargin();
- pi.pain.fillRectangle(x + rm, y1, x2 - rm, y2 - y1,
Color_selection);
+ pi.pain.fillRectangle(x + lm, y1, x2 - lm, y2 - y1,
+ Color_selection);
} else {
- int lm = bv_->leftMargin();
- pi.pain.fillRectangle(x + x2, y1, width() - lm - x2, y2
- y1, Color_selection);
+ pi.pain.fillRectangle(x + x2, y1, width() - rm - x2, y2
- y1,
+ Color_selection);
Are you sure? You just replaced left with right and right with left
here...
Otherwise the patch is just renaming and cosmetics so, provided that
you explain the above, I am OK with the patch. Putting Dov in copy so
that he is aware of your activity.
Abdel
Hi!
Hi Dov,
I'm not familiar enough with the painting code in order to be able to
provide any intelligent input. Best I can do at the moment is just to
test this to make sure that it works correctly also for RTL text. What
exactly should I look at?
Just check that the text and rectangle selection painting is fine within
insets.
Abdel.
Looks good. There's still a minor problem with RTL text, but it's not any worse
off with this patch than it was before. I think I actually know what the cause
may be, I'll provide more details tomorrow evening --- I've got to go now...
But meanwhile, this patch is OK by me...
Dov
