"Vincent van Ravesteijn - TNW" <[EMAIL PROTECTED]> writes: > Change::color() should indeed determine the color of a change. This > method then decides that we color the change according to the rank of > the author in the AuthorList. Then, it should ask AuthorList what the > rank is of the author and which color to assign to which rank.
It can do that, but not expose it to the rowpainter code. The rowpainter does not care about the method used to pick a color. > By the way, should Change::author not be a reference to an Author iso an > integer? The fact that we have the integer, makes that AuthorList > doesn't supply private information and that I had to/could create a > static method. Maybe. > No, it is not extreme.... I like to add that Change::UNCHANGED is aching > me. The type of a change saying there is no change ? (This might be part > of the design, as I think it occurs more often). Well, every character has a change type, which is often UNCHANGED. I'd prefer to have methods Change::deleted(), Change::inserted() and Change::unchanged(), it would make for shorter code. JMarc
