Vincent van Ravesteijn - TNW wrote:
It's a trade-off, as you say, but it's also possible to do this kind of change in two steps. First, clean up the existing code. Second, make your changes. Of course, you may not know how you want to clean it up until you've made your changes, so you have to go back and pretty much re-do everything. But at that point, it usually doesn't take too long.Yes, it's a general problem that I try to write patches that change the least as possible, so you can easily review and understand the changes, but this might introduce the 'errors' you mentioned. Moreover, I try to do things the same as it is already done in the code somewhere else, but, considering that that may be written a long time ago by different authors, that might not always be the best way (also referring to the comment of Andre on using char_type bb[] = { one_char }, although the comment is right and should be made). And of course, I have to improve my own skills.
rh
