Uwe Stöhr wrote:
>> this patch is wrong and causes completion stop working when tab is used
>> without popup. please revert.
>
> I can see no problem. I use TAB without popup.

i can see the problem even from the code :)

what happens for you with this recipe? :
1. newfile, ctrl+m
2. hit two keys \a
3. immediately (before popup appears) hit tab

(before this patch 'acute' gets completed on first hit
and accepted on second hit). now this stops work, so completion
completion 

>Now we have no regressions

well, you removed the basic task of completion  for a few glitches
in other parts of code.

>So new features need to respect existing behaviors and not the opposite.

while i agree with this sentence, for the time being please put it back.
the correct solution for tab key will require more time.

pavel

Reply via email to