[EMAIL PROTECTED] wrote: > Author: uwestoehr > Date: Sat Sep 6 23:10:59 2008 > New Revision: 26320 > > URL: http://www.lyx.org/trac/changeset/26320 > Log: > GuiWorkArea.cpp: allow to navigate in tables with the Tab key, patch by > Vincent > > Modified: > lyx-devel/trunk/src/frontends/qt4/GuiWorkArea.cpp > > Modified: lyx-devel/trunk/src/frontends/qt4/GuiWorkArea.cpp > URL: > http://www.lyx.org/trac/file/lyx-devel/trunk/src/frontends/qt4/GuiWorkArea.cpp?rev=26320 > ============================================================================== > --- lyx-devel/trunk/src/frontends/qt4/GuiWorkArea.cpp (original) > +++ lyx-devel/trunk/src/frontends/qt4/GuiWorkArea.cpp Sat Sep 6 23:10:59 2008 > @@ -847,7 +847,7 @@ > } > > // intercept keys for the completion > - if (ev->key() == Qt::Key_Tab) { > + if (completer_->popupVisible() && ev->key() == Qt::Key_Tab) { > completer_->tab(); > ev->accept(); > return;
this patch is wrong and causes completion stop working when tab is used without popup. please revert. currently more features want the tab key and more discussion will be needed imho. also there was rewuest that we should provide configurable bindings instead of hardcoding tab. pavel
