On Fri, Jul 11, 2008 at 01:05:33PM -0400, rgheck wrote: > Andre Poenitz wrote: >>> Index: src/BufferParams.h >>> =================================================================== >>> --- src/BufferParams.h (revision 25523) >>> +++ src/BufferParams.h (working copy) >>> @@ -15,8 +15,9 @@ >>> #ifndef BUFFERPARAMS_H >>> #define BUFFERPARAMS_H >>> +#include "Citation.h" >>> +#include "DocumentClassPtr.h" >>> #include "Font.h" >>> >> >> That's why I don't like it. BufferParams.h is used allover the place. >> >> However, it has already a Pimpl, so why is the DocumentClass not >> stored in BufferParams::Impl? >> >> > Sure. It could be put there. Then it would be OK with you?
If there's no #include pulling in <boost/shared_ptr.hpp> in one of the headers (or at least one of the important ones) I would not oppose using a shared_ptr - if it really solves a problem. Andre'
