rgheck wrote:
Abdelrazak Younes wrote:
rgheck wrote:
Andre Poenitz wrote:
But if the idea is to store the params _because they change_,
that should be a copy, i.e.
otherstack.top().bparams = new BufferParams(buffer_.params())
with a corresponing delete somewhere, shouldn't it?
Well, here's a patch I suggested previously. JMarc thought it might
be better to use a shared_ptr here. I have no strong views. You?
Isn't the attached patch simpler?
This doesn't make a copy of the BufferParams but just stores a pointer
to the old one. It has to make a copy.
Isn't that what I do here?
+ otherstack.top().bparams = new BufferParams(buffer_.params());
Abdel.
