On Thu, Jun 19, 2008 at 12:11 PM, Bennett Helm <[EMAIL PROTECTED]> wrote:
> On Thu, Jun 19, 2008 at 12:04 PM, Abdelrazak Younes <[EMAIL PROTECTED]> > wrote: > >> OK, I polished a few things there. It is very hard to get all the >>> >> use cases right so please do some testing and report back. The >>> good news is that I've uniformised the behaviour for all platforms. >>> >>> >>> With quick testing, it looks like a very nice present -- so shiny! A >>> couple of blemishes, though: >>> >>> 1. TOC doesn't work properly. (I'm guessing now that this is an >>> independent bug, which was the cause of my thinking before that I didn't >>> have TOC open when profiling, though the profile indicated I did.) When I >>> open the TOC and then close the document and reopen, the TOC drawer is not >>> visible. However Document > Outline *is* checked, and selecting it unchecks >>> it without altering the appearance of the window. Only selecting it a second >>> time results in the TOC being viewed. >>> >> >> Yes, somewhat related but something else. >> >> >>> 2. The first time a document is opened, it has too much visible: TOC, >>> source, and the standard, extra, and view update toolbars. Wouldn't it be >>> better to use document defaults for opening new windows? >>> >> >> Sure. And would you like some milk with your tea? That should be >> fixable... > > > And some sugar, too, please! Oh, and how about dinner to follow? 5 courses > sounds about right. ... > OK -- a more serious blemish. I just updated to r25326 (from 25325), and I get a crash on closing a window. Here's the backtrace: Program received signal EXC_BAD_ACCESS, Could not access memory. Reason: KERN_INVALID_ADDRESS at address: 0x244489e5 0x244489e5 in ?? () (gdb) bt #0 0x244489e5 in ?? () #1 0x001261bd in lyx::LyXFunc::getStatus (this=0x142cef0, [EMAIL PROTECTED]) at LyXFunc.cpp:388 #2 0x0010bd2a in lyx::getStatus ([EMAIL PROTECTED]) at LyX.cpp:1213 #3 0x004d348e in lyx::frontend::GuiView::updateToolbars (this=0xea275b0) at GuiView.cpp:929 #4 0x004d3b88 in lyx::frontend::GuiView::updateDialogs (this=0xea275b0) at GuiView.cpp:2271 #5 0x004d91a3 in lyx::frontend::GuiView::event (this=0xea275b0, e=0xbfffdd78) at GuiView.cpp:751 #6 0x005ab26f in QApplicationPrivate::notify_helper () at LyX.cpp:1303 #7 0x005b151c in QApplication::notify () at LyX.cpp:1303 #8 0x0036bf01 in lyx::frontend::GuiApplication::notify (this=0x142d440, receiver=0x244489e5, event=0x244489e5) at GuiApplication.cpp:1142 #9 0x00b63834 in QCoreApplication::notifyInternal () at LyX.cpp:1303 #10 0x005af56d in QApplication::setActiveWindow () at LyX.cpp:1303 #11 0x005fa377 in QApplicationPrivate::globalEventProcessor () at LyX.cpp:1303 #12 0x946d6763 in DispatchEventToHandlers () #13 0x946d5b9d in SendEventToEventTargetInternal () #14 0x946d5a02 in SendEventToEventTargetWithOptions () #15 0x9475af0d in PostActivateEvent () #16 0x9475a99b in HiliteAndActivateWindow () #17 0x94998135 in AdjustToNewWindowActivation () #18 0x9475bba8 in PotentiallyAdjustToNewWindowActivation () #19 0x9475baf2 in BringToFrontAndActivateWindow () #20 0x9475b9af in WindowData::SelectWindow () #21 0x0061060c in QWidget::activateWindow () at LyX.cpp:1303 #22 0x005fa8b8 in QApplicationPrivate::globalEventProcessor () at LyX.cpp:1303 #23 0x946d6763 in DispatchEventToHandlers () #24 0x946d5b9d in SendEventToEventTargetInternal () #25 0x946d5a02 in SendEventToEventTargetWithOptions () #26 0x9470483c in ToolboxEventDispatcherHandler () #27 0x946d6b1c in DispatchEventToHandlers () #28 0x946d5b9d in SendEventToEventTargetInternal () #29 0x946f24ee in SendEventToEventTarget () #30 0x005f55a1 in qt_mac_send_event () at LyX.cpp:1303 #31 0x00601a42 in QEventDispatcherMac::processEvents () at LyX.cpp:1303 #32 0x00b62f41 in QEventLoop::processEvents () at LyX.cpp:1303 #33 0x00b6306a in QEventLoop::exec () at LyX.cpp:1303 #34 0x00b65d61 in QCoreApplication::exec () at LyX.cpp:1303 #35 0x00116519 in lyx::LyX::exec (this=0xbffff378, [EMAIL PROTECTED], argv=0xbffff3bc) at LyX.cpp:442 #36 0x000023c9 in main (argc=1, argv=0xbffff3bc) at main.cpp:46 Bennett