On Mon, Apr 07, 2008 at 01:12:11AM +0200, Joost Verburg wrote:
> Leuven, E. wrote:
> [...]
> This is really a great feature. I can now copy graphics from any Windows
> application!
>
> Joost
Cool stuff.
Nevertheless, could we try stick to LyX style also in Windows-only code?
E.g:
> +#ifdef Q_WS_WIN
> +
> +static FORMATETC setCf(int cf)
> +{
> + FORMATETC formatetc;
Tabs for indentation.
> + formatetc.cfFormat = cf;
> + formatetc.ptd = NULL;
> + formatetc.dwAspect = DVASPECT_CONTENT;
> + formatetc.lindex = -1;
> + if (cf == CF_ENHMETAFILE) formatetc.tymed = TYMED_ENHMF;
> + if (cf == CF_METAFILEPICT) formatetc.tymed = TYMED_MFPICT;
if (cf == CF_ENHMETAFILE)
formatetc.tymed = TYMED_ENHMF;
> + if (cf == CF_METAFILEPICT) formatetc.tymed = TYMED_MFPICT;
> + return formatetc;
> +}
> +
> +
> +static bool canGetData(int cf, IDataObject * pDataObj)
> +{
> + FORMATETC formatetc = setCf(cf);
> + return pDataObj->QueryGetData(&formatetc) == S_OK;
> +}
> +
> +
> +class QWindowsMimeMetafile : public QWindowsMime {
> +public:
> + QWindowsMimeMetafile()
> + : QWindowsMime()
> + {}
> + ~QWindowsMimeMetafile() {}
[Empty desctructors and constructors are not needed]
> + bool canConvertFromMime(const FORMATETC & formatetc, const QMimeData *
> mimeData) const;
> + bool canConvertToMime(const QString & mimeType, IDataObject * pDataObj)
> const;
> + bool convertFromMime(const FORMATETC & formatetc, const QMimeData *
> mimeData, STGMEDIUM * pmedium) const;
> + QVariant convertToMime(const QString & mimeType, IDataObject *
> pDataObj, QVariant::Type preferredType) const;
> + QVector<FORMATETC> formatsForMime(const QString & mimeType, const
> QMimeData * mimeData) const;
> + QString mimeForFormat(const FORMATETC &) const;
> +};
We have 'Type const & t';
> +
> +QVariant QWindowsMimeMetafile::convertToMime(
> + const QString & mimeType, IDataObject * pDataObj,
> + QVariant::Type preferredType) const
> +{
> + QVariant ret;
> +
> + if (canConvertToMime(mimeType, pDataObj)) {
Tab again...
Andre'
