On Feb 26, 2008, at 10:23 AM, Abdelrazak Younes wrote:

Closing a child document when the master is open seems to work correctly: if it has unsaved changes, you're asked to save, after which it gets reloaded in the background. That's nice.

Good.

However:
1. Nothing has change with respect to my command-sequence: when multiple files are open, each in their own window, they all get closed.

I guess this is a bug in the Mac plaftorm. Please try without your command-sequence, just with a simple window close. There is no cross button in the top-right corner on Mac? just "window-close" should suffice if not.

It works properly if I click on the red circle on the top left corner (the Mac equivalent of the cross button). But entering window-close in the command buffer (on its own -- not in a command-sequence) results in all documents closing.

2. If I open a master document, all the child documents get opened in the background. However, if I then close the master document, the child documents remain in the background (and then get reloaded via the sessions file when I restart LyX). That shouldn't happen.

I agree but this has always been like this. Not a reason to not change this behavior though of course.


Also, I'm not sure what you intend with closing a document when it is open in multiple windows. Currently, such a document gets closed in all windows when attempting to close it in one.

No, no, this change is about closing a given window, not a document. If a document is closed (as opposed to hidden), it will be of course closed in all windows that view this document.

I see. That's not how things work on Mac in those rare programs that allow a document to be open in multiple windows. I can see the rationale going both ways. On the one hand, clicking the red circle in the title bar is normally the same as closing the document, and so it ought to have the same effect as File > Close; hence, both should simply close the window. On the other hand, File > Close *means* close the file (and not just the window). Of these, I prefer the former but without good reason.

With my recent change, if you close a window that is viewing a document that is not viewed elsewhere, then this document will be close, i.e. it will not be available in the view menu of the other windows. Clearer?

Yes ... except (as noted above) window-close doesn't work this way for me.

Bennett

Reply via email to