On Feb 26, 2008, at 9:20 AM, Abdelrazak Younes wrote:

Bennett Helm wrote:
On Feb 25, 2008, at 3:22 PM, Abdelrazak Younes wrote:
Bennett Helm wrote:
On Feb 25, 2008, at 2:32 AM, Abdelrazak Younes wrote:
4. Using a keybinding to close a buffer and then the window that contained it (command-sequence buffer-close ; window- close) results in a crash. Curiously, doing this via the command buffer works fine. Here's the backtrace:

Should be fixed now.
I've now checked. It doesn't crash, but it's not working properly. If I have 2 documents open, each in its own window and I use the above keybinding to close one of the windows, it ends up closing not only that window but also *both* documents. (Of course, it should only close the one document that was in that window.)

That's weird indeed.

So IIRC you want to close all files in a given window if they are not viewed in some other windows, don't you?
Yes.

OK, I've implemented something like this. Please tell me what you think.

Closing a child document when the master is open seems to work correctly: if it has unsaved changes, you're asked to save, after which it gets reloaded in the background. That's nice. However:

1. Nothing has change with respect to my command-sequence: when multiple files are open, each in their own window, they all get closed.

2. If I open a master document, all the child documents get opened in the background. However, if I then close the master document, the child documents remain in the background (and then get reloaded via the sessions file when I restart LyX). That shouldn't happen.

Also, I'm not sure what you intend with closing a document when it is open in multiple windows. Currently, such a document gets closed in all windows when attempting to close it in one.

Bennett

Reply via email to