Am 02.02.2008 um 17:48 schrieb Abdelrazak Younes:
Abdelrazak Younes wrote:
Stefan Schimanski wrote:
I reorganised the code and moved the dialog and saving code into
the frontend (i.e. Clipboard.cpp) now. The CutAndPaste function is
very simple now.
I looked at the patch just now and realized that you are
introducing Clipboard.cpp while I think you should just put the
code in GuiClipboard and use Qt methods. For example in
Clipboard::GraphicsData::save() you could use QImage::save(),
couldn't you?
Same remark for getPastedGraphicsFileName(), you just don't need
the additional file IMHO.
Just to add some clarification to my recommendation: with Andre', we
managed to reduce the file in frontends/ quite significantly and
most of the remaining one are pure virtual interface so it would
nice if frontends/Clipboard.h stays a pure virtual interface.
Of course I can move everything to GuiClipboard. My motivation not to
do that was that this code is independent of the specific frontend in
fact (even if there is only the Qt frontend now). The saving code for
example and the interaction with the FileDialog do not use Qt.
Stefan
