Abdelrazak Younes wrote:
Abdelrazak Younes wrote:
Stefan Schimanski wrote:
I reorganised the code and moved the dialog and saving code into the
frontend (i.e. Clipboard.cpp) now. The CutAndPaste function is very
simple now.
I looked at the patch just now and realized that you are introducing
Clipboard.cpp while I think you should just put the code in
GuiClipboard and use Qt methods. For example in
Clipboard::GraphicsData::save() you could use QImage::save(), couldn't
you?
Same remark for getPastedGraphicsFileName(), you just don't need the
additional file IMHO.
Just to add some clarification to my recommendation: with Andre', we
managed to reduce the file in frontends/ quite significantly and most of
the remaining one are pure virtual interface so it would nice if
frontends/Clipboard.h stays a pure virtual interface.
And I hope you don't mind my comments. Feel free to ignore me if that is
the case of course.
Abdel.
