On Tue, 8 Aug 2000, Juergen Vigna wrote:
> >>
> >> Please apply this.
>
> Applied, will commit soon, just some observations:
>
> - you really should fix your indentation, when I look into insetgraphics.C
> you mix tab-indentation (8 chars normally) and 4 spaces, so the indent
> level is not equal on the whole file.
I know, I used to work with 4 spaces indentation, I now switched to tabs
(on my screen it shows as 4 spaces). This was done to conform with the
rest of you, I will soon enough pass all my sources through astyle (a
pretty printer and formatter) to get everything in a single look (the
tabs mainly).
I simply wanted to have a patch that shows the fixes and wont be obscured
with the style changes.
> - I don't like the bv_ variable in insetgraphics.C. We now have only one
> BufferView, but you should think for the future in which it should be
> possible to open more then one BufferView. You probably should work with
> a Buffer * pointer as that is really unique and for now you can access
> the bufferview with buffer->users().
Hmm, ok. I simply need a way to tell lyx to update my inset when the image
loads, I dont mind how this is achieved. Actually using a signal could be
a good idea (I think, something like an updateMe signal on the inset).
> I had only a fast look and this is what I've seen. I know this is in
> development work, I just wanted to make sure you go in the right direction ;)
No problem, If I won't get any input (good or bad) I'll think that my code
is ignored :-)
--
Baruch Even
http://techst02.technion.ac.il/~sbaruch/ (My Site)
http://rpghost.com/jindor/ (My brothers AD&D site)
" Learn to laugh ... it's the path to true love! "
- The Angel in the movie Michael
