Jean-Marc Lasgouttes wrote:

> Here is what it looks like when using a std::set for features.
> Simpler, isn't it?

Indeed.

> BTW, there is a semantics problem: in a layout file, when I do
> Require foo
> Require bar
> does it mean that I want foo and bar, or only bar?

the former. I also took care that requiring in included files in handled.
This is important for modules, for instance.

> InsetLayout used to implement the later solution and I changed it to
> the former.

Good.

> I only tested that the code compiles, I do not have proper test files
> (but I am fairly sure it is correct). UserGuide and EmbeddedObject
> crash with
> pegase: src/lyx
> Assertion triggered in bool lyx::EmbeddedFile::extract() const by failing
> check "enabled()" in file ../../lyx-devel/src/EmbeddedFiles.cpp:134
> Aborted
> 
> I do not think it is related to the patch, but who knows?

Don't think so. I saw this also.

> Customization refuses to typeset because of a missing \inputencoding
> macro (I guess listings support should require an encoding). I do not
> think again it is my fault, do you see it?

I cannot test now.

Jürgen


Reply via email to