On Wed, 2 Aug 2000, Angus Leeming wrote:
> Allan> > Fixed those so it at least compiles and links. Someone else will have to
> Allan> > fix the crash when you open the TOC. I didn't try the other modified
> Allan> > dialogs. Gotta do some thesis work now.
>
> I take it these compile/link errors were due to no "make updatesrc" in
> src/frontends/xforms/forms?
No I did the "make install" there to update everything and added the
form_toc.[hC] files as per Lars' request for someone with xforms-0.88 to
do this.
Unfortunately somewhere along the line xforms/Makefile.am was missing
several entries and after adding these I found that Lars' patching to
remove InsetCommand::hide() needed other changes. And then it took a
couple other corrections to get things working.
So what I thought was going to be a simple matter of regenerate the form_*
files and rebuild ready for a commit turned into a major pain in the neck.
> Allan> > I think my previous arguments that new dialogs should be worked on in a
> Allan> > separate branch until properly working are starting to prove correct.
>
> Well, I'm don't. I'd consider this stuff to be stable in that the difficult
> stuff was creating the very first dialog. The rest are essentially
> cut-and-paste jobs.
Sure most of this is cut and paste but as was demonstrated today we still
end up broken or incomplete patches applied.
> The only way we can test this code properly is to have a fairly wide
> user base. This is a perfect example; code works fine on my box with
> my compiler, but not on yours. It is CVS head after all.
Try "make maintainer-clean" and a complete rebuild next time or at least
make sure your patch includes a patch for Makefile.am. It is CVS HEAD
after all. It'd be nice to not break it with what should have been a
simple addition.
Fuck it, this is silly. I'm in a bad mood which isn't helping.
Patches work best when the person applying it doesn't have to do anything
extra.
> For all that, I'm truly sorry. Will take more care to initialise stuff
> in future.
That was just a small straw breaking the camels back. I gotta go, friends
coming around to look at photos tonight.
You do good work Angus just try to remember to check what you are doing.
The FormCommand scheme looks pretty good BTW. ( Now that it works :P )
Allan. (ARRae)
