Jean-Marc Lasgouttes wrote:
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
I have looked up this code and the situation in
Paragraph::Private::latexInset seems to be very fishy indeed. Part of
the code for newlines has been kept and part has been removed... No
latex is output, but texrow.newline is still invoked. \\protect is
invoked there and is thus separated from the rest of the latex code.
It is a mess and extending the code without trying to at least
mitigate the mess is not a good thing...
Before you accuse me of something else this warning was there before
I've cleaned up this mess a bit.
I do not accuse you, but it looks like you feel guilty :)
Not at all, the situation was exactly the same before my code shuffling.
I am pretty sure of that. Some other previous commit is responsible for
this warning.
My point was:
* prior situation: no latex output is done by InsetNewline itself,
everything is done in paragraph (very strange, but everything in one
place)
This was still the case after my cleanup.
* wanted situation: everything is done in InsetNewline itself (very
logical and everything in one place)
Yes, and I didn't try to do this change because I don't know LaTeX.
* current situation: some latex output is done in paragraph, some is
done by the inset
That's Uwe's doing, not mine.
I think that the current code is less clean than it was for this
particular situation
Look at the svn history. I didn't remove any code that was in use.
Abdel.
