Abdelrazak Younes <[EMAIL PROTECTED]> writes: >> I have looked up this code and the situation in >> Paragraph::Private::latexInset seems to be very fishy indeed. Part of >> the code for newlines has been kept and part has been removed... No >> latex is output, but texrow.newline is still invoked. \\protect is >> invoked there and is thus separated from the rest of the latex code. >> >> It is a mess and extending the code without trying to at least >> mitigate the mess is not a good thing... > > Before you accuse me of something else this warning was there before > I've cleaned up this mess a bit.
I do not accuse you, but it looks like you feel guilty :) My point was: * prior situation: no latex output is done by InsetNewline itself, everything is done in paragraph (very strange, but everything in one place) * wanted situation: everything is done in InsetNewline itself (very logical and everything in one place) * current situation: some latex output is done in paragraph, some is done by the inset I think that the current code is less clean than it was for this particular situation (I agree that the other parts of your cleanups were definite gains, AFAICS). JMarc
