Le 31 oct. 07 à 08:40, Abdelrazak Younes a écrit :
Dov Feldstern wrote:
Hi!
I committed a fix to a bug due to the Font/Language separation,
which was causing LFUN_LANGUAGE to not work (http://www.lyx.org/
trac/changeset/21305).
Thanks.
This solution may be a bit of a hack --- I'm not familiar enough
with the bigger picture.
It is not a hack. Your change makes the code more explicit and that
is good. It also reveals the inherent problem that the Font/
Language mix brings.
Perhaps a better solution would be to further separate between
Font and Language, by changing toggleFree to deal with them in a
totally separate manner, or even to have separate functions for
the language and font.
Right, separate functions is what we should aim at.
Dov, I'm really not surprised to hear about that at this point! Where
is the simplification? I presume that next step should be to separate
concepts as well, i.e. use char sets (insets, why not) in place of
char attributes... ;-)
If anyone feels like looking into this, feel free.
This should be a mid-term goal. You, as a proponent of char
attributes (for spelling, styles, etc) should be interested in
doing that ;-)
lol
Mael.
