Jürgen Spitzmüller wrote:
Helge Hafting wrote:
Leave every option enabled
and just don't do anything when the user tries something impossible.
This should be an easy patch.
I doubt this will be much easier (you still have to check). And it's risky: we
had countless crashes in tha past because an "impossible" action wasn't
disabled.
But an action shouldn't be able to proceed if it is impossible to
succeed. This should be independent for the enabling/disabling of icons
and/or menu items.
Moreover, with the current architecture, a status change is not
immediately reflected in the relevant icon, you will have to trigger a
new action to update all the other action statuses. Take the "paste"
action for example; it the clipboard is empty, the icon will get
disabled only _after_ you move the cursor. This means that clicking in
this icon will in effect trigger the "paste" action.
Summary: we should always check the action status before we proceed.
A bdel.
