Uwe Stöhr wrote:
> The patch fixes
> http://bugzilla.lyx.org/show_bug.cgi?id=3242
>
> - When the height value is zero, no option is set in the output. (see
> coment 0) 

What if a user explicitely wants 0pt? A zero dimension box is often used to 
correct the adjustment in LaTeX.

> - I changed the UI to make the optional parameter really optional 
> using a check box. (see comment 5)

I don't think a checkbox is really needed. What we should do is to allow for 
an empty input, which means that the optional argument is not used.

However, if this turns out to be complicated to implement, I'm fine with a 
checkbox as well. But then the first change (0 = empty) is not needed.

> Is this now correct?

The second patch looks good, except for the treatment of zero.

Jürgen

Reply via email to