Quoting Martin Vermeer <[EMAIL PROTECTED]>:
> On Tue, Aug 28, 2007 at 10:53:09PM +0200, Abdelrazak Younes wrote:
> > >If you don't want cursor_on_row back, consider making the row signature
> > >sensitive to change tracking.
> > >
> > Yes, that's the proper solution even though I am not sure I can
> > understand the change tracking code...
>
> You don't have to... just make sure that the change tracking status of
> every character is included in the CRC computation formula.
Year, I've figured that out already and the fix is in.
>
> Note BTW that also underbar (from the text settings dialog) changes the
> text appearance without changing the metric... currently it doesn't cause
> problems but that might change.
I'll have a look, thanks.
> You should catch all these cases.
Sure and I also count on you to remind those ;-) I am sure any drawing problem
will be detected in time and corrected before 1.6.0. I hope you don't mind me
ripping out this code but I really think this should be done now, early in the
development cycle. I didn't do it in the previous devel series because of
insufficient knowledge (which I have now). You are very welcome to help me in
the design and coding :-)
>
> This CRC thing was at the time considered rather a kludge ;-/
I know a lot more things in the code that are much more of a kludge. The CRC is
quite OK in my opinion. We could also replace that with a Paragraph::changed()
status but I am not going to do that now.
> > FYI, I want drawing to be as dumb as possible; I want everything screen
> > related to be decided at metrics update time. That's where I am heading
> > with these cleanups. I believe we won't need the singlePar optimisation
> > anymore when I'm done because every ParagraphMetrics will know exactly
> > which row needs to be redrawn.
>
> OK, I assume you know what you're doing ("singleRow"?)
Yes.
Abdel.
