Jean-Marc Lasgouttes wrote:
Asger Ottar Alstrup <[EMAIL PROTECTED]> writes:
Abdel tested his code, and is confident in it. He has proven his
skills many times. He makes mistake, just like everyone else. This has
never stopped LyX from progressing, and will not now.
I do not think the problem is in this area. Nobody questioned the
interest or the necessity of the patch. It is just that, when somebody
says "just merge it when you have 10 minutes", you expect that the
person has re-read it to make sure that it will not remove some recent
unrelated patches. You expect anyway that the person has re-read it to
make sure that he did it right (that would catch the problem above).
You expect that he has re-read it to produce a commit log that is
synthetic and that will helpfully explain what is going on (that
would catch the two problems above, surprise!).
JMarc, I asked if someone was willing to help me before the trunk
diverge too much. I had zero proposal for help. So I had to do it
myself. For this I had to sync my branch with trunk and unfortunately I
forgot one or two revision because this bloody SVN doesn't do merge
tracking (it's coming in the next version apparently). The small
problems you are describing happened only because of that.
Don't pretend that the small problems encountered is the reason for the
resistance. The reason was that you wanted me to split the patch in ways
that you could understand, period.
Abdel, you asked at some time whether you have to prove yourself. I do
not think anybody on this list doubts of you programming skill. I
guess what makes things difficult is more a problem of attitude.
Maybe you (not only you) should question your attitude as well? The
reason why I insist so much in those things is that I really think you
are too conservative and that you are scaring off wannabe developers. I
am pretty sure of that.
I had
to literally get the information bit by bit to be able to know what
I don't think I was reluctant to give you this information. Did I refuse
to give you this information? Excuse me if I cannot expose the
information in a way that is simple to understand.
your intent was with child document (yes, the kind of "read the code;
if you do not understand it, then it is not something that conerns
you" discourse is not very useful).
I was talking generally. But it is true that most of the time, the only
real way to understand a patch is to read the original code. Sorry about
that.
Abdel.
