"Bo Peng" <[EMAIL PROTECTED]> writes: > The patch > > 1. add checksum_ to Buffer::pimpl_ to store the checksum of the current > buffer. > > 2. checksum_ is calculated when the buffer is loaded or saved in lyx. > > 3. Buffer::isExternallyModified() is added to test if file checksum > equals stored checksum_ > > 4. File->revert is enabled if isExternallyModified() is true.
All this is OK. I think I would have preferred a time-based solution rather than a crc based (especially since lyx::sum seems to be broken on windows http://bugzilla.lyx.org/show_bug.cgi?id=3172). > 5. I like File->reload a lot better than File->revert so I also change > the menu name. This part can be removed if you guys like revert > better. Note, however, that the LFUN is actually named > LFUN_BUFFER_RELOAD. As I wrote already, this is not OK. Nobody does that. JMarc
