Jean-Marc Lasgouttes schrieb:
José> I was expecting Jean-Marc opinion on this.
My opinion:
- I do not know what this 'usedtoolbars' thing is. And the comments in
ToolbarBackend.h do not help much. Edwin, is it your doing?
- it seems that the problem was that we need to check whether a given
toolbar exists. If it is the case, it would be much simpler to just
add a ToolbarBackend::hasToolbar method.
Wait a minute... My patch fixes three things at a time:
- An untranslated user message
- A crash if the toolbar specification in a *.ui file is inconsistent
- A reasonable error message if toolbar-toggle is called with an
invalid argument
In contrary, I am not responsible for "usedtoolbars" and it wasn´t my
intention to clean up or refactor this area of the code. Moreover, IMHO
it does not make sense to call "hasToolbar" before every occurrence of
"getToolbarInfo". It is just too easy to forget the first call and we
also waste a few CPU cycles.
This said, could you please tell me (again) whether my patch is
acceptable as it is?
Michael
