>>>>> "Michael" == Michael Gerz <[EMAIL PROTECTED]> writes:
Michael> In contrary, I am not responsible for "usedtoolbars" and it
Michael> wasn´t my intention to clean up or refactor this area of the
Michael> code.
Michael> Moreover, IMHO it does not make sense to call "hasToolbar"
Michael> before every occurrence of "getToolbarInfo". It is just too
Michael> easy to forget the first call and we also waste a few CPU
Michael> cycles.
I do not think it would change much, actually, but this is not very
important. At least, I would prefer
if (!tbi)
to
if (tbi == 0)
The point I did not like was the change from getState to getInfo, but
now I see that there is one point where you need the full info.
Michael> This said, could you please tell me (again) whether my patch
Michael> is acceptable as it is?
Now that I look at it (even) more closely, I have a question: we used
to have two version of getToolbars, which only differred by the fact
that one is const.
With your patch we know kind of randomly decide that one should be for
usedtoolbars (you have not told me yet what it is, the fact that you
did not write it does not help my comprehension :) qnd the other one
for defined toolbars. Why?
JMarc
