Yes, I think it is what we want. The space that was typed at the end of the Hebrew was meant to separate it from the next word. By switching its language, we achieve exactly that.
But here you press space F12 space. And what you mean is that you press space to separate words, switch to LTR, press space by accident (so it's dropped) and continue. Ok, maybe, a minor issue anyway.
But now take: abc|[WERBEH_]ghi, logically abc|_HEBREWghiYou cannot type in the space now without the EPM eating it up on the next key press, altough you should be able to.No, I'm not sure that you should be able to. Again (and this is true also for the above case) --- you have to work hard to even create the situation you're talking about --- it can't happen by just typing, because when the character after the first space was typed in, the space's language would already change languages. If the user is working hard to create problematic situations, then either he wants it that way, or else he'll have to work hard to get out of it too. There are too many edge cases, and the fact is, most of the really don't make too much sense, and there is *no* correct way to deal with it, because it doesn't make sense, so you don't know *what* the user is trying to do...
Ok, if you just type LTR text, F12, space, HEBREW, F12, space, English... everything is fine. Then you don't get the space at the (visual) end of the HEBREW part. If you edit you RTL parts and somehow get such a space you will not understand that you are unable to put a space in front of the RTL. If that's what you want, let it be... I have the feeling it's not right. But it's maybe also only a minor thing which can be fixed later.
The point of the patch is to answer to the fact that it is very common for people to not pay attention to the order of the language switch and the spaces, and the patch fixes that.Again, we can still think about the EPM, I'm not sure whether or not it's correct and/or necessary. But I don't see why the current patch has to wait until that issue is worked out. I think its current behavior is correct, and certainly better then the current situation.
Ok, EPM is another issue, maybe even a matter of taste one could enable/disable in the preferences. But first we should get this into svn. José? Dov's patch has my OK.
Another thing, you saw the getPosVisually method in the rtl_spaces patch? I think it's what we need to implement visual movement, no? It takes care to correctly update the bidi tables and calculates relative visual positions.
Stefan
PGP.sig
Description: Signierter Teil der Nachricht
