Stefan Schimanski wrote:
Am 08.06.2007 um 13:30 schrieb Dov Feldstern:
Stefan Schimanski wrote:
I like it! The only thing missing is the EPM which works with the
patch. I added this in set_font_spaces_magic.patch. Moreover I made
your patch a bit simpler. I hope it's ok like that.
I incorporated some of the changes you proposed. But the main change
you made I'd rather not use: I don't want to set the entire font of
the space; only it's language (think underbar, size, etc. --- some of
these things may matter even though it's only a space).
Attached is the patch after the corrections you suggested, except for
that one.
Regarding the other stuff --- now the EPM is removing *too* much. Try
typing: 'abc' <space> F12 DEF <space> F12 -- at this point, the
trailing space already disappeared; which is perhaps correct from the
EPM's point of view, but not from the users... As soon as the user
would type something in after the space, then the space_magic would
take care of that space anyway, so the EPM shouldn't be doing it.
There may not be any way around this --- it may be that to fix what we
were complaining about with the EPM, you have to do it this way, I
don't know. But the current behavior is not, IMO, what the user wants.
In fact my patch is supposed to make sure (and here it does in fact,
strangely not for you) that you can type the space and it is not removed
when you switch back to LTR. But maybe it's just related to the follow
stupid question:
What is this F12 key btw, I couldn't find any reference anywhere. I
always used the text format dialog to switch to Hebrew. With that it
works. Where is F12 bound? Which function does it trigger. Here I only
get a space from F12.
Right, sorry... F12 is in the hebrew bindings, and all it does is bind
to "language hebrew" (which toggles back and forth between Hebrew and
the primary language, as set in the preferences; note that this is *not*
the document language, but the default language). I'm not sure what
switching from the dialog does, maybe that's why we're seeing different
behavior. The normal way to switch is using the "language" command
though: you can either add it to your key bindings, or type it in
directly in the minibuffer.
On top of those, we can continue experimenting with the EPM --- though
again, I'm not sure anymore that it's really necessary, and I also
agree somewhat with the issues that Andre' raised...
I think you are right. EPM can come later. We should put in your patch
ASAP. But there is one thing missing I think, have to try first to be
sure: take "abc[ WERBEH]ghi". Can you type space then in front of the
"g"?
Good question --- but it actually seems to be working; it looks like the
space magic kicks in, and switches the space's language. Then the
existing EPM, I guess, removes the new space just typed in. But the
result is that it's working correctly.
Also note that the situation probably wouldn't arise in the first place,
because as soon as 'g' was typed, the space magic would already have
changed the previous space back to LTR.
I expect you can't we at least needs the part of the patch from the
insertChar method which makes this possible. With that addition your
patch has my OK.
I suggest keeping the attached patch at the *bottom* of the stack now
--- I think we all more or less agree with it, and as soon as we get
the OKs, it can be committed (I'd still like to hear from Ran and Guy
and any other Bidi users about it, though). So the attached is to be
applied to a clean svn tree.
With the upper addition and another OK by somebody else, I commit it...
Great, thanks! (but I'm not adding anything else, see above).
So any other OKs? Ran, Guy, Miki? Jose?
Stefan
