Edwin Leuven wrote: > > The bug is that the top- and bottomlines can no longer be toggled in > > booktabs mode. > > i don't think so. > > you cannot toggle the top line on the *first* row and the bottom line on > the last row. > > this is intentional: we don't allow the user to toggle these atm (just > create a booktabs table with no lines set. you'll see that it will have > a top and bottom line). the thing i did is to make this visible.
I see. This is a bug. A booktabs table without top- or bottomrule is perfectly sensible. However, I see that the bug is there without your patch as well. > > About the ui: I find it irritating that I have to select the whole row > > now to switch lines on/off. > > you find it irritating because it is different, but ui-wise i think it > is much more intuitive... Not for me. And why should we do it differently than we used to (and differently to Word and Ooo)? > > I think I would prefer the other way round: do as we > > used to if nothing is selected (i.e. toggle the line for the whole row), > > and toggle clines only if one or more cells are selected (this is also > > what Ooo does). > > ... moreover, we cannot select single cells so this won't work. Which is another bug which should be resolved first :-( (but you have a point). > > I'm sure these things can be fixed quickly, but it also shows that even > > such "small" enhancements need to be tested and discussed. > > i think i just convinced you that the patch is fine... > > ;-) The patch is fine, but not for 1.5.0. (IMHO) Jürgen
