Stefan Schimanski wrote:
So, the first P.S. is history now. I added an offset from the x_target
after moving to the next line. Using that the cursor knows when it is
actually meant to be on the target, but had to move slightly left or
right to be between character.
Try it in the user manual. You can scroll many pages down and the cursor
stays exactly in the same column, just jumping left and right a few
pixel sometimes to fit between the characters.
I tested the patch as much as I could. Scrolled through the user manual,
my thesis and the test file. Looks all fine. Just one small issue with
RTLs: try to go into a long RTL line, then jump down into a display
math. The column is wrong. Nothing critical, but should be investigated.
I will go to bed now. So José or Abdel, feel free to commit the patch
after testing it please for RC1. Haven't committed it myself yet,
because I want somebody else with a unprejudiced eye to have look and
try it out, also on other platforms.
It seems to work fine on WinXP. WRT the code, the only comment I have is
that you should get rid of Text::cursorUp() and cursorDown() which are
worth nothing now. Two less thing to migrate to TextMetrics :-)
Abdel.
- Re: Text::cursor* clean up, target_x, right display math... Abdelrazak Younes
-
