So I converted everything back to the old structure, but with the fixes of targetX and everything else. What is remaining now is the correct logic of LFUN_FINISHED_UP/DOWN. Which insets should get those LFUNs? As far as I understand the ones "below" the one which dispatched the LFUN_UP/DOWN. But why? What are they doing with it? Don't get the intuition, and as usual there is zero documentation in the code, just a few weird LFUN handlers.
Moreover it seems that after handling LFUN_UP/DOWN in a math inset, the FINISHED_UP/DOWN inset were never created because Cursor::goUpDown always returned true and therefore also Cursor::up/ down did, hence the block to send FINISHED_UP/DOWN in InsetMathNest::dispatch were never executed. Anybody has an idea?
Stefan
Stefan Schimanski wrote:Am 26.05.2007 um 11:20 schrieb Abdelrazak Younes:Right, I didn't notice that yet, will look into it. I know the reason for the behaviour, so it should be easy enough to fix.Stefan Schimanski wrote:Am 26.05.2007 um 11:14 schrieb Abdelrazak Younes:Yes, the case where the cursor is jumping up and down in a math inset. It was caused by the wrong boundary value coming from Test::editXY. Was a one-liner....Stefan Schimanski wrote:If we put this patch into RC1 we rather should put it in today than tomorrow evening ten minutes before the release. As far as I can tell it works fine and there are no immediate show stoppers in the patch. But by committing it now others might test it at least a bit before releasing it to the public on Sunday.@Abdel, Alfredo, José: Does it make sense?Did you solve the in-inset case in your latest patch? I think this will bring a lot of complaints if not fixed.No, I mean within multi-line insets (FootNotes, Comments, etc).Great! Once you solve that issue, it is OK for me. Abdel.
PGP.sig
Description: Signierter Teil der Nachricht
