Bernhard Roider wrote:
Abdelrazak Younes schrieb:
[EMAIL PROTECTED] wrote:
Author: broider
Date: Sun May 13 21:53:06 2007
New Revision: 18293
URL: http://www.lyx.org/trac/changeset/18293
Log:
fix cursor movement (up/down) problem at the end of lines in insets
and table cells.
Some in-source-code comments are in order Bernhard. Especially since
you removed mine that were not enough already.
You're right.
But there is another issue that i got aware today: The case of rtl text.
The attached patch should handle this correctly, but please could
somebody have a look at it?
Bernhard
Hi!
Actually, that's why I originally looked at your patch the other day ---
to make sure that it doesn't interfere with cursor movement in RTL,
which I'm working on now. But I think I checked it, and it seemed to be
okay, also before this fix. What exactly is the test case for this, I'll
take a look at it again?
I didn't try to understand exactly what you did in this new patch, but
I'm not sure that there should be any need for it: isn't the cursor
position here the logical cursor position? In RTL paragraphs, the first
letter of the paragraph (on the right) is still 0, and the positions
increase to the left instead of to the right. But logically, it
shouldn't be any different that LTR in this case, I think.
Thanks for being aware of RTL --- most non-RTL developers don't even
think of this! :)
Dov
