Dov Feldstern schrieb:
Bernhard Roider wrote:
Abdelrazak Younes schrieb:
[EMAIL PROTECTED] wrote:
Author: broider
Date: Sun May 13 21:53:06 2007
New Revision: 18293
URL: http://www.lyx.org/trac/changeset/18293
Log:
fix cursor movement (up/down) problem at the end of lines in insets
and table cells.
Some in-source-code comments are in order Bernhard. Especially since
you removed mine that were not enough already.
You're right.
But there is another issue that i got aware today: The case of rtl
text. The attached patch should handle this correctly, but please
could somebody have a look at it?
Bernhard
Hi!
Actually, that's why I originally looked at your patch the other day ---
to make sure that it doesn't interfere with cursor movement in RTL,
which I'm working on now. But I think I checked it, and it seemed to be
okay, also before this fix. What exactly is the test case for this, I'll
take a look at it again?
Look at those lines:
00000a000000000000000x00000
0000000000000
00000c0000000f0000000y0000000
1. You start with the cursor at the position marked 'x' and press the down-key twice. You want to
end up at 'y', not at 'f'.
2. You start with the cursor at the position marked 'a' and press the down-key, advance to the end
of the second line and press the down key again. You want to end up at 'f' and not at 'c'.
(The second case is the one that was originally not working and therefore the
initial patch)
I didn't try to understand exactly what you did in this new patch, but
I'm not sure that there should be any need for it: isn't the cursor
position here the logical cursor position?
The cursor position is, but AFAICS the x-target is the coordinate of the cursor on the screen (in
pixels i think).
Bernhard
