Sorry, I missed this thread.
Yes my commit was really incomplete, I also forget to commit the images.

> - Never ever commit stuff to 1.4 only, unless that is a fix for a bug not
> present in 1.5. We always need to have current documentation in 1.5, too.
> Then there is a chance that somebody who modifies a feature will update the
> documentation at the same time. Otherwise that will not happen for sure.

OK, I'll do this for the next time. I didn't commit the Extended-Insets manual to trunk because it is not yet actualized for LyX 1.5. It's in now but I'm still working on it.

> - Always ask Jean-Marc for permission to commit to 1.4, even for tiny
> fixes.

I asked him if the new docs can go in before I committed (this wan in december). The next time I'll post my patches before committing to avoid such beginner faults.

> - In this particular case, you have to add "Extended-Insets" to tge list at
> the top of lib/doc/depend.py

I did this but the TOC-file generation still fails. There is a bug in bugzilla about the missing TOC-files because this is the case also for all LyX 1.4.x releases:
http://bugzilla.lyx.org/show_bug.cgi?id=2947

I get:
-------
D:\LyXSVN\lyx-devel\lib\doc>python depend.py
# This is a Makefile for the TOC.lyx files.
# It was automatically generated by depend.py
#
# First come the rules for each xx_TOC.lyx file. Then comes the
# TOCs target, which prints all the TOC files.

TOC.lyx: $(srcdir)/Intro.lyx $(srcdir)/FAQ.lyx $(srcdir)/Tutorial.lyx $(srcdir)/
UserGuide.lyx $(srcdir)/Extended-Insets.lyx $(srcdir)/Extended.lyx $(srcdir)/Cus
tomization.lyx
        PYTHONPATH=$(top_builddir)/lib/lyx2lyx python -tt $(srcdir)/doc_toc.py

tocfiles = TOC.lyx

D:\LyXSVN\lyx-devel\lib\doc>
-----

The script runs till the end, but no TOC-file is created. Also Makefile.depend 
is not updated.

> - If you add new files, you have to add them to the appropriate Makefile.am
> and to scons_manifest. Otherwise they will not show up in the binary
> package.

Done now, but what about the images in the lib/clipart folder, are they also handled by Makefile.am, if yes how?

> You also have to set the svn:eol-style flag if it is not a binary
> file, otherwise wwe will get useless diffs because of line ending changes.

I wasn't aware of this, because the diffs looked fine in svnlog and in trac. I 
set this flag now.

regards Uwe

Reply via email to