Georg Baum wrote:

Now getStatus will not be called if assertions are disabled. That is wrong, we want getStatus to update fs even if assertions are disabled. We assert that getStatus actually made a decision, but that is not the only thing getStatus does.

Oh shit... I've thought that getStatus was not touching anything, sorry about that.

Modified: lyx-devel/trunk/src/text3.C
URL: http://www.lyx.org/trac/file/lyx-devel/trunk/src/text3.C?rev=16500

==============================================================================
--- lyx-devel/trunk/src/text3.C (original)
+++ lyx-devel/trunk/src/text3.C Thu Jan  4 14:29:35 2007
@@ -144,7 +144,6 @@
                replaceSelection(cur);
if (sel.empty()) {
-                       const int old_pos = cur.pos();
                        cur.insert(new InsetMathHull(hullSimple));
                        BOOST_ASSERT(old_pos == cur.pos());
                        cur.nextInset()->edit(cur, true);

old_pos is not unused as can be seen two lines below the deleted one.

Problem is that MSVC gives a warning for unused variable when compiling in release mode (with assertion disabled). CMake now treats these warning as errors.

So I need to change CMake.

Sorry again,
Abdel.




Georg



Reply via email to