Am Donnerstag, 4. Januar 2007 14:29 schrieb [EMAIL PROTECTED]: > Modified: lyx-devel/trunk/src/lyxfunc.C > URL: http://www.lyx.org/trac/file/lyx-devel/trunk/src/lyxfunc.C?rev=16500 > ============================================================================== > --- lyx-devel/trunk/src/lyxfunc.C (original) > +++ lyx-devel/trunk/src/lyxfunc.C Thu Jan 4 14:29:35 2007 > @@ -516,9 +516,8 @@ > if (inset) { > FuncRequest fr(LFUN_INSET_MODIFY, cmd.argument()); > FuncStatus fs; > - bool const success = inset->getStatus(cur, fr, fs); > // Every inset is supposed to handle this > - BOOST_ASSERT(success); > + BOOST_ASSERT(inset->getStatus(cur, fr, fs)); > flag |= fs; > } else { > FuncRequest fr(LFUN_INSET_INSERT, cmd.argument());
Now getStatus will not be called if assertions are disabled. That is wrong, we want getStatus to update fs even if assertions are disabled. We assert that getStatus actually made a decision, but that is not the only thing getStatus does. > Modified: lyx-devel/trunk/src/text3.C > URL: http://www.lyx.org/trac/file/lyx-devel/trunk/src/text3.C?rev=16500 > ============================================================================== > --- lyx-devel/trunk/src/text3.C (original) > +++ lyx-devel/trunk/src/text3.C Thu Jan 4 14:29:35 2007 > @@ -144,7 +144,6 @@ > replaceSelection(cur); > > if (sel.empty()) { > - const int old_pos = cur.pos(); > cur.insert(new InsetMathHull(hullSimple)); > BOOST_ASSERT(old_pos == cur.pos()); > cur.nextInset()->edit(cur, true); old_pos is not unused as can be seen two lines below the deleted one. Georg
